deps: Upgrade all; fix warning from json_serializable#151
Merged
chrisbobbe merged 3 commits intozulip:mainfrom Jun 7, 2023
Merged
deps: Upgrade all; fix warning from json_serializable#151chrisbobbe merged 3 commits intozulip:mainfrom
chrisbobbe merged 3 commits intozulip:mainfrom
Conversation
And update Flutter's supporting libraries to match, namely matcher, test, test_api, and test_core.
There are currently no upgrades that `--major-versions` would add beyond these.
Otherwise we get the following warning when running build_runner
(wrapped here for readability):
[WARNING] json_serializable on lib/api/route/users.dart:
The version constraint "^4.8.0" on json_annotation
allows versions before 4.8.1 which is not allowed.
I believe that warning was introduced with the json_serializable
upgrade from 6.6.2 to 6.7.0 in f28dd0b / zulip#137.
Closed
Collaborator
|
Thanks! In testing on macOS, I've realized that I think there are changes in |
Member
Author
|
Ah, good thought, thanks. Those changes are independent of the ones in this PR, though, right? In particular it doesn't look like these changes affect any native plugin code; for example these don't introduce any changes under So I think the best thing would be to make those changes as a separate PR. |
Collaborator
|
Oh OK, right, that makes sense. I'll go ahead and merge this one, then, and send that other work as a separate PR. |
Collaborator
|
Sent #158. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
deps: Upgrade Flutter to latest main, 3.11.0-18.0.pre.81
And update Flutter's supporting libraries to match,
namely matcher, test, test_api, and test_core.
deps: Upgrade packages within constraints (flutter pub upgrade)
There are currently no upgrades that
--major-versionswould addbeyond these.
deps: Bump json_annotation lower bound to latest, 4.8.1
Otherwise we get the following warning when running build_runner
(wrapped here for readability):
I believe that warning was introduced with the json_serializable
upgrade from 6.6.2 to 6.7.0 in f28dd0b / #137.